Stop JP from trashing conversations on its own
Children, 0 of 8 done on the board
- TodoT-1n2tta7Treat a draft-only conversation directory as pending
- TodoT-1n2tta8Validate conversations read-only and report failures
- TodoT-1n2tta9Restore conversations JP trashed on its own
- TodoT-1n2ttaaAdd jp conversation trash and untrash
- TodoT-1n2ttabAdd jp conversation repair
- TodoT-1n2ttacAdd jp doctor
- TodoT-1n2ttadRecord the policy that JP never moves user data itself
- In ProgressT-1n2tta6--no-persist queries leave a query draft in user storage
On every run, Workspace::sanitize() moves each conversation directory that fails structural validation into conversations/.trash/ without asking. At default verbosity it prints nothing, because the only report is a warn! trace. Users can accumulate hundreds of auto-trashed directories (often marked missing metadata.json) without knowing why or having a built-in command to restore them.
This parent ticket reverses the auto-trash decision of RFD 052:
- JP never moves user data on its own. Startup validation reads and reports. It does not repair.
- Report loudly and carry on. Unloadable conversations are reported on stderr after the command's output. The command runs normally on the valid conversations.
- Trashing is a user action.
jp conversation trash/untrashandjp conversation repairact only when asked.jp doctorlists problems and suggests fixes. - Invalid conversations stop at the edges. They are caught where the store is scanned, and never enter the conversation index or reach core code. Defensive handling must not spread through the codebase.
- Undoing what JP already did is temporary. Restoring auto-trashed conversations lives in one isolated module in
jp_cli, built to be deleted once users no longer have auto-trashed data.
Causes identified or suspected for missing metadata.json directories:
--no-persistqueries write a query draft (QUERY_MESSAGE.md) into user storage; a failed run leaves the file behind in a directory without metadata.- A fresh conversation composes its draft in an untitled directory before its first write, so a failure or interrupt before the first flush leaves a draft-only directory.
- Trashed directories that already carry a title in their directory name are not explained by either draft-only path and still need investigation.
Done when every child is done. Whether to backfill an RFD superseding RFD 052's auto-trash design is decided afterwards.